This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Make sure confirmations are updated - Closes #716 #735
+141
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because they have higher "confirmations" field
if the app is not in background, because we want to show updated number of "confirmations"
because we need to update "confirmations" number
... because transactions table was slow when it was re-rendering all rows.
Format it with 'k', e.g. 1k instead of 1324, 23k instead of 23456 so that we don't have to re-render too often.
slaweet
force-pushed
the
716-confirmations-not-updated
branch
from
b49812d to
6d5e7a8
Compare
reyraa
previously approved these changes
Sep 14, 2017
This reverts commit 2da347e.
reyraa
approved these changes
Sep 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This became a bigger issue than it looked at the beginning. For explanations of all changes see individual commit messages.
Closes #716